Attention is currently required from: Chris Wang, Eric Peers. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52650 )
Change subject: mb/google/guybrush: Add STAPM values to overridetree ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52650/comment/194607a0_f0ee0a34 PS1, Line 38: register "slow_ppt_limit_mW" = "25000"
I don't see a system_config=2. […]
I just found the chart for Cezanne in the thermal design guide. 2 is the correct value for Guybrush. 3 is the value for Mancomb. See Doc #56483 V1.03 Table 4. "FP6 Processor Thermal Control Parameters" for value meanings.
https://review.coreboot.org/c/coreboot/+/52650/comment/2fa5289b_6da311b9 PS1, Line 40: register "slow_ppt_time_constant_s" = "5"
I remember hearing that we need to set at 9, but we might want this higher longterm. […]
Right now, I believe the value is 5, at least until a bug says otherwise.