Attention is currently required from: Angel Pons. Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62759 )
Change subject: hp/z220_cmt_workstation: Add variant of z220_sff_workstation ......................................................................
Patch Set 1:
(6 comments)
Patchset:
PS1: Patch revised, pushing now.
File src/mainboard/hp/z220_sff_workstation/Kconfig:
https://review.coreboot.org/c/coreboot/+/62759/comment/112afbbb_f91a3e3f PS1, Line 1: BOARD_HP_Z220_VARIANT
As this symbol is for a group of boards, I'd rename it to `BOARD_HP_Z220_SERIES`
Done
https://review.coreboot.org/c/coreboot/+/62759/comment/6801f42f_983daf82 PS1, Line 52:
Please don't make a copy of data.vbt, just keep it where it is and add this here: […]
Done
https://review.coreboot.org/c/coreboot/+/62759/comment/08af6cad_644c5fa4 PS1, Line 53: config VGA_BIOS_FILE : string : default "pci8086,0102.rom" : : config VGA_BIOS_ID : string : default "8086,0102"
Where did this come from? Please remove, it doesn't make sense for a board with a socketed CPU.
Done
File src/mainboard/hp/z220_sff_workstation/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/62759/comment/1f4f5320_571bcc0b PS1, Line 3:
nit: spaces not needed
Done
File src/mainboard/hp/z220_sff_workstation/variants/z220_cmt_workstation/gpio.c:
PS1:
Are there many differences between the GPIO settings?
There's a handful of gpios that are different, not many. You can diff the two files easily as the whitespace is the same.