Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33386 )
Change subject: vboot: use vboot2 API to set initial secdatak value ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33386/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33386/1//COMMIT_MSG@18 PS1, Line 18: TEST=make clean && make test-abuild Please manually confirm (e.g. hack up a version with a memcmp() or something) that both size and content of the old and new versions are identical.
https://review.coreboot.org/#/c/33386/1/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/#/c/33386/1/src/security/vboot/secdata_tpm.c@232 PS1, Line 232: VB2_SECDATAK_SIZE Uhhh... maybe I'm bad at math, but this is currently defined to 14 in vboot, and I only count 13 bytes? Do we need to fix something there before we start using it? (chromeos-tpm-recovery also uses 0xd to recreate the space.)