[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add Cometlake-S and CMP-H skus

[Gaggery Tsai (Code Review)]

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36684 )

Change subject: src/soc/intel: Add Cometlake-S and CMP-H skus
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36684/2/src/soc/intel/cannonlake/bo... 
File src/soc/intel/cannonlake/bootblock/report_platform.c:

https://review.coreboot.org/c/coreboot/+/36684/2/src/soc/intel/cannonlake/bo... 
PS2, Line 48: { CPUID_COMETLAKE_H_S_6_2_P0, "Cometlake-H/S P0 (6+2)"
> Why is this one gone?

I think the original P0 info is incorrect or mapping to older version. With the latest doc #605546, CPU ID 0xA0650 is G0. P0 is 0xA0651 and there is no (6+2) sku for P0.