Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44905 )
Change subject: mb/google/puff: Convert ASL file to new DPTF dt impl ......................................................................
Patch Set 8:
(13 comments)
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 270: # Default DPTF Policy for all Puff boards if not overridden
Let's remove it; it was more meaningful when it was in a baseboard devicetree.
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 274: 90
The first values should be 90, 85, 80, 75, 70, 65. […]
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 280: .thresholds={TEMP_PCT(50, 90),
The second values should be 95, 85, ..., 45. […]
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 288: CHARGER
CPU
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 298: 3000
15000
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 304: 15000
25000
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 305: 60000
64000
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/faffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 279: ## Active Policy
Remove?
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 289:
register "policies. […]
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 292:
register "policies. […]
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 297: 3000
10000
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 303: 15000
25000
Done
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 304: 60000
51000
Done