Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48065 )
Change subject: mb/google/brya: Add GPIO stubs ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48065/6/src/mainboard/google/brya/v... File src/mainboard/google/brya/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48065/6/src/mainboard/google/brya/v... PS6, Line 7: ramstage space after ramstage
https://review.coreboot.org/c/coreboot/+/48065/6/src/mainboard/google/brya/v... File src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/48065/6/src/mainboard/google/brya/v... PS6, Line 9: /* The next set of functions return the gpio table and fill in the number of : * entries for each table. */ ``` /* * The next set... */ ```
Also go ahead and fill it out to 96 chars wide for new files
https://review.coreboot.org/c/coreboot/+/48065/6/src/mainboard/google/brya/v... File src/mainboard/google/brya/variants/brya0/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/48065/6/src/mainboard/google/brya/v... PS6, Line 3: MAINBOARD_GPIO_H I think we're typically doing the underscores before & after e.g. `__MAINBOARD_GPIO_H__`