[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Allow including FSPT at specified offset

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43398 )

Change subject: drivers/intel/fsp2_0: Allow including FSPT at specified offset
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43398/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43398/1//COMMIT_MSG@11 
PS1, Line 11: specify FSPT location in CBFS and user option to include FSPT.
> > The FSP-T binary is not relocatable, it seems. […]

Is is written in integration guide that the binary must be placed at the address specified in FSP binary header, it is valid for all FSP binaries, i.e. FSP-T, FSP-M and FSP-S. IIRC all three have the relocation tables which are meant to runtime relocate the binary. But it isn't implemented in assembly that loads and executes FSP-T in coreboot. That is why first free location is bad.