Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46930 )
Change subject: soc/mediatek/common: Add common API for loading firmwares ......................................................................
Patch Set 21:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46930/20//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46930/20//COMMIT_MSG@10 PS20, Line 10: memory
Can be moved to the previous line.
Done
https://review.coreboot.org/c/coreboot/+/46930/20//COMMIT_MSG@13 PS20, Line 13: mtlib_init_mcu: Load dpm.pm in 13 msecs (14004 bytes)
Please update the format.
Done
https://review.coreboot.org/c/coreboot/+/46930/20/src/soc/mediatek/common/in... File src/soc/mediatek/common/include/soc/mtlib_common.h:
https://review.coreboot.org/c/coreboot/+/46930/20/src/soc/mediatek/common/in... PS20, Line 8: *
One space before "*/"
Done
https://review.coreboot.org/c/coreboot/+/46930/20/src/soc/mediatek/common/in... PS20, Line 8:
Only one space. Same below.
Done
https://review.coreboot.org/c/coreboot/+/46930/20/src/soc/mediatek/common/in... PS20, Line 9: *
One space before "*/"
Done
https://review.coreboot.org/c/coreboot/+/46930/20/src/soc/mediatek/common/mt... File src/soc/mediatek/common/mtlib.c:
https://review.coreboot.org/c/coreboot/+/46930/20/src/soc/mediatek/common/mt... PS20, Line 21: .
Remove ". […]
Done