Attention is currently required from: Julius Werner, Nico Huber.
Alper Nebi Yasak has posted comments on this change by Alper Nebi Yasak. ( https://review.coreboot.org/c/coreboot/+/80364?usp=email )
Change subject: mainboard/qemu-aarch64: Get top of memory from device-tree blob ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/emulation/qemu-aarch64/cbmem.c:
https://review.coreboot.org/c/coreboot/+/80364/comment/a8a46cf6_4fe5efc4?usp... : PS2, Line 12: top = fdt_get_memory_top((void *)_dram);
On all the other Arm devices we've followed the example from x86 to use `((uintptr_t)4 * GiB)` as cb […]
Thanks for the explanation. I've limited it to 4 GiB now, but with `-1` as it overflows when we have >2 GiB RAM with 32-bit RISC-V (DRAM starts at 2 GiB).
I guess I should do it to the DRAM probing code below as well, but should I do it in this change?
(Putting the `-1` outside might be a typo, I don't remember)