Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45964 )
Change subject: soc/amd/picasso: Die if the workbuf is missing two boots in a row
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45964/2/src/soc/amd/picasso/bootblo...
File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45964/2/src/soc/amd/picasso/bootblo...
PS2, Line 142: if (cmos_read(RTC_CLK_ALTCENTURY) != 0xff &&
src/soc/amd/picasso/pmutil.c already has vbnv_cmos_failed() implementation. […]
I agree, but vbnv_cmos_failed is just this one cmos read, which I'm already using in this function, so I just pulled the cmos read in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45964
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I949f94e78d25720f6cd7e81de8d030084e267f29
Gerrit-Change-Number: 45964
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Oct 2020 23:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment