EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39674 )
Change subject: mb/google/deltaur: Add initial GPIO configuration
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39674/2/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39674/2/src/mainboard/google/deltau...
PS2, Line 439: PAD_CFG_NF(GPD3, NONE, DEEP, NF1),
Please UP20K. https://review.coreboot.org/c/coreboot/+/30374
https://review.coreboot.org/c/coreboot/+/39674/2/src/mainboard/google/deltau...
PS2, Line 474: * TODO: I don't see the correct UPDs available in the partial headers
I will check this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f6398808809492dcb345ccaa09e199fa35e40cf
Gerrit-Change-Number: 39674
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 20 Mar 2020 05:17:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment