Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34797 )
Change subject: soc/intel/common/smm: Add missing printk statement ......................................................................
soc/intel/common/smm: Add missing printk statement
SMI trap handler was missing a printk statement, which caused Coverity to flag "data &= mask;" as a redundant operation.
Change-Id: I71da74e5e08e7d7e6d61c1925db19324efd73f0a Found-by: Coverity CID 1381621 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34797 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/smm/smitraphandler.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/common/block/smm/smitraphandler.c b/src/soc/intel/common/block/smm/smitraphandler.c index bfa9846..974c489 100644 --- a/src/soc/intel/common/block/smm/smitraphandler.c +++ b/src/soc/intel/common/block/smm/smitraphandler.c @@ -108,6 +108,7 @@ /* Trapped write data */ data = pcr_read32(PID_PSTH, PCR_PSTH_TRPD); data &= mask; + printk(BIOS_DEBUG, " iotrap read data = 0x%08x\n", data); } }