Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38836 )
Change subject: security/intel/stm: Check for processor STM support ......................................................................
Patch Set 1:
(3 comments)
The variables should have been renamed in a separate commit.
https://review.coreboot.org/c/coreboot/+/38836/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38836/1//COMMIT_MSG@10 PS1, Line 10: VTX VTx
https://review.coreboot.org/c/coreboot/+/38836/1/src/security/intel/stm/StmP... File src/security/intel/stm/StmPlatformSmm.c:
https://review.coreboot.org/c/coreboot/+/38836/1/src/security/intel/stm/StmP... PS1, Line 172: cpu: %d CPU %d
https://review.coreboot.org/c/coreboot/+/38836/1/src/security/intel/stm/StmP... PS1, Line 172: BIOS_DEBUG This should be at least NOTICE or even WARNING.