[coreboot-gerrit] Change in coreboot[master]: bootblock: Support normal/fallback mechanism again

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37760 )

Change subject: bootblock: Support normal/fallback mechanism again
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/Makefile.inc 
File src/arch/x86/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/Makefile.inc@1... 
PS5, Line 115: bootblock-$(CONFIG_BOOTBLOCK_NORMAL) += bootblock_normal.c
> The simple one always boots fallback. This is how they were named with romcc bootblock too.

Thanks. I still find it confusing in the naming, but it's consistent. :)

https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/bootblock_norm... 
File src/arch/x86/bootblock_normal.c:

https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/bootblock_norm... 
PS5, Line 37: 	if (do_normal_boot()) {
> This is where cmos flag comes into play.

ok. Thanks. I must be confused.