Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40261 )
Change subject: src/mb/google/volteer: workaround for GPIO PM on s0ix entry/exit ......................................................................
Patch Set 1:
(15 comments)
I do not understand, why this has to be done in ACPI/ASL, and not in coreboot proper?
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@7 PS1, Line 7: src/mb/google/volteer: workaround for GPIO PM on s0ix entry/exit Please make it a statement by adding a verb (in imperative mood).
Add workaround …
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@6 PS1, Line 6: : src/ Remove.
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@10 PS1, Line 10: causing causes
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@10 PS1, Line 10: tpm TPM
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@10 PS1, Line 10: gpio pm GPIO PM
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@11 PS1, Line 11: had has
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@11 PS1, Line 11: s0ix S0ix
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@12 PS1, Line 12: s0ix S0ix
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@12 PS1, Line 12: gpio pm GPIO PM
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@12 PS1, Line 12: asl ASL
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@15 PS1, Line 15: This patch adds three methods platform specific methods Dot/period at the end.
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@15 PS1, Line 15: methods Duplicate. Remove.
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@21 PS1, Line 21: preparing to sleep Dot/period at the end.
https://review.coreboot.org/c/coreboot/+/40261/1//COMMIT_MSG@24 PS1, Line 24: waking up Dot/period at the end.
https://review.coreboot.org/c/coreboot/+/40261/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/40261/1/src/mainboard/google/voltee... PS1, Line 4: * Only one blank line?