Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Nick Vaccaro, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80206?usp=email )
Change subject: mb/google/rex: Organize models configs alphabetically
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/rex/Kconfig:
https://review.coreboot.org/c/coreboot/+/80206/comment/ac8532bf_5a9a858b :
PS1, Line 66: BOARD_GOOGLE_MODEL_DEKU
What's the difference between BOARD_GOOGLE_MODEL_DEKU and BOARD_GOOGLE_DEKU ?
I don't see any BOARD_GOOGLE_MODEL_XXX in brya's Kconfig, wasn't familiar with that.
this is the easy way to avoid config duplication between each variants having QS and ES SoC. we have decided to create a model which selects all common config between QS and ES variants.
@Nick, I'm marking resolve. let me know otherwise
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80206?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0acc2cec21b4607856127b04c400ec416f0c0dd2
Gerrit-Change-Number: 80206
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 26 Jan 2024 06:12:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment