HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37818 )
Change subject: {drivers,southbridge}: Replace min() with MIN()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37818/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37818/2//COMMIT_MSG@7
PS2, Line 7: {drivers,southbridge}: Replace min() with MIN()
Why?
1- min()/max() , here looks like a function not a macro
2- to remove min()/max() from stdlib.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37818
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica03d9aec8a81f57709abcac655dfb0ebce3f8c6
Gerrit-Change-Number: 37818
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 19 Dec 2019 04:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment