Attention is currently required from: Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48262 )
Change subject: mb/emulation/qemu-q35: Add support for SMM_TSEG with parallel MP init ......................................................................
Patch Set 8:
(2 comments)
File src/cpu/qemu-x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/48262/comment/0f3412ab_2d60cc31 PS8, Line 42: depends on PARALLEL_MP In the light of the other comment thread, shouldn't this depend on X86_32?
File src/mainboard/emulation/qemu-q35/cpu.c:
https://review.coreboot.org/c/coreboot/+/48262/comment/9914d456_ec2213f6 PS8, Line 17: /* FIXME: on X86_64 the save state size is smaller than the size of the SMM stub */ Ack
So taking the MAX(stub size, save state size) during the mp init would work
Iow., the MP init code assumes this value is high enough to fit something else (the stub)? Soundslike something to fix there.