Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60284 )
Change subject: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_PROTO0 ......................................................................
mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_PROTO0
Deprecating Herobrine Proto0 board. The Proto board is very different from the Proto0 board (ie: Most GPIOs have been remapped). Deprecating and reusing the GOOGLE_BOARD_HEROBRINE Kconfig for Proto1 and reslotting the old GOOGLE_BOARD_HEROBRINE source under GOOGLE_BOARD_HEROBRINE_PROTO0 config. Want to keep the code around in case somebody needs it but we can remove this code in future after we recall all the Proto0 devices.
BUG=b:211644878 BRANCH=None TEST=emerge-herobrine coreboot
Change-Id: I67a0b282710031b927ce9022c7c535bd8d4ca1aa Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/herobrine/Kconfig M src/mainboard/google/herobrine/Kconfig.name M src/mainboard/google/herobrine/mainboard.c 3 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/60284/1
diff --git a/src/mainboard/google/herobrine/Kconfig b/src/mainboard/google/herobrine/Kconfig index c4c943e..f724a52 100644 --- a/src/mainboard/google/herobrine/Kconfig +++ b/src/mainboard/google/herobrine/Kconfig @@ -47,6 +47,7 @@
config MAINBOARD_PART_NUMBER default "Herobrine" if BOARD_GOOGLE_HEROBRINE + default "Herobrine_Proto0" if BOARD_GOOGLE_HEROBRINE_PROTO0 default "Senor" if BOARD_GOOGLE_SENOR default "Piglin" if BOARD_GOOGLE_PIGLIN default "Hoglin" if BOARD_GOOGLE_HOGLIN diff --git a/src/mainboard/google/herobrine/Kconfig.name b/src/mainboard/google/herobrine/Kconfig.name index c0e995c..706e0d6 100644 --- a/src/mainboard/google/herobrine/Kconfig.name +++ b/src/mainboard/google/herobrine/Kconfig.name @@ -6,6 +6,10 @@ bool "-> Herobrine" select BOARD_GOOGLE_HEROBRINE_COMMON
+config BOARD_GOOGLE_HEROBRINE_PROTO0 + bool "-> Herobrine_Proto0" + select BOARD_GOOGLE_HEROBRINE_COMMON + config BOARD_GOOGLE_SENOR bool "-> Senor" select BOARD_GOOGLE_HEROBRINE_COMMON diff --git a/src/mainboard/google/herobrine/mainboard.c b/src/mainboard/google/herobrine/mainboard.c index a2e0786..f2432d9 100644 --- a/src/mainboard/google/herobrine/mainboard.c +++ b/src/mainboard/google/herobrine/mainboard.c @@ -59,7 +59,7 @@ qupv3_se_fw_load_and_init(QUPV3_1_SE5, SE_PROTOCOL_I2C, MIXED); /* Touch I2C */ qupv3_se_fw_load_and_init(QUPV3_0_SE7, SE_PROTOCOL_UART, FIFO); /* BT UART */
- if (CONFIG(BOARD_GOOGLE_HEROBRINE)) { + if (CONFIG(BOARD_GOOGLE_HEROBRINE_PROTO0)) { /* Audio I2C */ qupv3_se_fw_load_and_init(QUPV3_0_SE0, SE_PROTOCOL_I2C, MIXED); /* Trackpad I2C */