Attention is currently required from: Angel Pons.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69019 )
Change subject: nb/intel/sandybridge: Specify supported memory types ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Thank you.
File src/northbridge/intel/sandybridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/69019/comment/460d1e39_1533e907 PS1, Line 18: select USE_DDR3
Why not select these from `config NORTHBRIDGE_INTEL_SANDYBRIDGE` instead?
If I'm not wrong, all other nb/Kconfig are using "NORTHBRIDGE_SPECIFIC_OPTIONS"
I don't know why current northbridge is different :p
(I'm also ok to move DDR selection to config NORTHBRIDGE_INTEL_SANDYBRIDGE if you want)