Attention is currently required from: Felix Held, Martin L Roth, Michał Żygowski, Piotr Król.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79083?usp=email )
Change subject: nb/amd/pi/00730F01: introduce and use chipset devicetree
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79083/comment/6089a400_94d4edac :
PS2, Line 16: on end # XHCI HC0 muxed with EHCI 2
: device ref sata on end
: device ref ehci_0 on end # USB EHCI0 usb[0:3] is connected
: device ref ehci_1 on end # USB EHCI1 usb[4:7]
: device ref lpc_bridge on
thoughts on aligning on/off, end, and the comments on tab stops throughout the file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79083?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6970c2f6e6d661d40406586f4e6eeb05bcd07979
Gerrit-Change-Number: 79083
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Thu, 16 Nov 2023 03:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment