Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47395 )
Change subject: elog: Add new wake source codes
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h
File src/include/elog.h:
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h@123
PS1, Line 123: #define ELOG_WAKE_SOURCE_PME_TBT 0x2d
Yep, I was waiting until these got +2'd before I pushed that change too 😊
Done
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h@124
PS1, Line 124: ELOG_WAKE_SOURCE_PME_TCSS_XHCI
yep
Done
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h@126
PS1, Line 126: ELOG_WAKE_SOURCE_PME_TCSS_DMA0
I thought about that as well... that sounds fine to me. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47395
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5dae6514c2776b30418a390c4da53bda0b2d456
Gerrit-Change-Number: 47395
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Nov 2020 17:34:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment