build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47723 )
Change subject: zotac/ad04: [git squash] Initial mainboard code added ......................................................................
Patch Set 2:
(102 comments)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Bi... File src/mainboard/zotac/ad04/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Bi... PS2, Line 11: static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Bi... PS2, Line 11: static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Bi... PS2, Line 14: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Bi... PS2, Line 32: ((MEM_DATA_STRUCT*)ConfigPtr)->ParameterListPtr->DDR3Voltage = VOLT1_5; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Oe... File src/mainboard/zotac/ad04/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Oe... PS2, Line 79: * Platform Specific Overriding Table allows IBV/OEM to pass in platform information to AGESA line over 96 characters
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Oe... PS2, Line 80: * (e.g. MemClk routing, the number of DIMM slots per channel,...). If PlatformSpecificTable line over 96 characters
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Oe... PS2, Line 81: * is populated, AGESA will base its settings on the data from the table. Otherwise, it will line over 96 characters
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Oe... PS2, Line 95: WRITE_LEVELING_SEED(ANY_SOCKET, ANY_CHANNEL, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED, WLSEED), line over 96 characters
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/Oe... PS2, Line 96: HW_RXEN_SEED(ANY_SOCKET, ANY_CHANNEL, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED), line over 96 characters
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ir... File src/mainboard/zotac/ad04/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ir... PS2, Line 81: if (sum != pirq->checksum) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... File src/mainboard/zotac/ad04/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 39: [0x00] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 41: [0x08] = 0x00,0xF1,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 43: [0x10] = 0x1F,0x1F,0x1F,0x0A,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 45: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 47: [0x30] = 0x0A,0x0B,0x0A,0x0B,0x0A,0x0B,0x0A, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 49: [0x40] = 0x0B,0x0B, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 51: [0x50] = 0x0A,0x0B,0x0A,0x0B space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 56: [0x00] = 0x10,0x11,0x12,0x13,0x14,0x15,0x16,0x17, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 58: [0x08] = 0x00,0x00,0x00,0x00,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 60: [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x12,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 62: [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 64: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x12, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 66: [0x40] = 0x11,0x13, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 68: [0x50] = 0x10,0x11,0x12,0x13 space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 90: {GFX_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_NC, PIRQ_NC}}, /* VGA: 01.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 91: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 04.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 92: {NB_PCIE_PORT2_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 05.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 93: {NB_PCIE_PORT3_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* NIC: 06.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 94: {NB_PCIE_PORT4_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* miniPCIe: 07.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 95: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SATA: 11.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 96: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI1: 12.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 97: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC}}, /* EHCI1: 12.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 98: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI2: 13.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 99: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 13.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 100: {SMBUS_DEVFN, {PIRQ_SMBUS, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* SMBUS: 14.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 101: {IDE_DEVFN, {PIRQ_NC, PIRQ_IDE, PIRQ_NC, PIRQ_NC}}, /* IDE: 14.1 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 102: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* HDA: 14.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 103: {SB_PCI_PORT_DEVFN, {PIRQ_H, PIRQ_E, PIRQ_F, PIRQ_G}}, /* PCI bdg: 14.4 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 104: {OHCI4_DEVFN, {PIRQ_NC, PIRQ_NC, PIRQ_OHCI4, PIRQ_NC}}, /* OHCI4: 14.5 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 105: {SB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D}}, /* miniPCIe: 15.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 106: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ma... PS2, Line 107: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/mp... File src/mainboard/zotac/ad04/mptable.c:
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/mp... PS2, Line 59: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/mp... PS2, Line 103: #define IO_LOCAL_INT(type, intr, apicid, pin) \ macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/mp... PS2, Line 104: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ro... File src/mainboard/zotac/ad04/romstage.c:
https://review.coreboot.org/c/coreboot/+/47723/2/src/mainboard/zotac/ad04/ro... PS2, Line 20: /* /1* Multi-function pins switch to GPIO0-35, these pins are shared with PCI pins *1/ */ line over 96 characters