Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31502 )
Change subject: [WIP]device/pci_rom: Add ATRM method ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31502/1/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31502/1/src/device/pci_rom.c@326 PS1, Line 326: acpigen_write_rom(cbrom, cbrom_length); Do we still need _ROM in AMD case? If not, how about passing the method name here? Then we wouldn't need the additional, redirecting method.