Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36291 )
Change subject: lib/romstage_save: Add methods to pass on romstage information ......................................................................
Patch Set 13:
Do you really think all that infrastructure you're envisioning there (if it's really possible to build that at all, which I'm not sure about) is really worth it? Seems a bit overkill for a not *that* common problem to me. For many of copy-into-CBMEM use cases we have, you gotta copy it into CBMEM but you also have to do some extra stuff (e.g. timestamps and console need to merge in the early BSS buffer in ramstage, vboot workbuffer needs to be updated with the new size, etc.) so even if you built some common solution for that, I think most cases would still need a custom callback for that. I feel what we have right now is probably good enough?
Same goes for what this patch does, isn't that a bit overkill for what really just needs to be a global variable and a CBMEM_INIT_HOOK?