build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )
Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_FAFT_KEY_OVERIDE setting
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36518/14/src/soc/qualcomm/common/qc...
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/36518/14/src/soc/qualcomm/common/qc...
PS14, Line 166: if (CONFIG(QC_SDI_ENABLE) &&
suspect code indent for conditional statements (8, 24)
https://review.coreboot.org/c/coreboot/+/36518/14/src/soc/qualcomm/common/qc...
PS14, Line 167: (!(VB2_GBB_FLAG_FAFT_KEY_OVERIDE & vb2api_gbb_get_flags(ctx)))) {
'OVERIDE' may be misspelled - perhaps 'OVERRIDE'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63f35c94bc6c60934ace5fe0fd9176443059b354
Gerrit-Change-Number: 36518
Gerrit-PatchSet: 14
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: ashk@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Dec 2019 16:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment