Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44086 )
Change subject: vendorcode/amd/fsp/picasso Fix type 17 smbios misalignment
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44086/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44086/1//COMMIT_MSG@7
PS1, Line 7: /amd/fsp/picasso
No problem. Please keep these coming while i'm learning the processes and format.
It's usually of the form:
path/to/folder: Commit summary
Where "path/to/folder" is often abbreviated. We usually drop the "src/" prefix, and abbreviate mainboard, vendorcode, northbridge, southbridge to mb, vc, nb, sb respectively
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ba7e2a4fb82c7b0b77ee7c6c075e6211d4f6adf
Gerrit-Change-Number: 44086
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 31 Jul 2020 18:04:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment