Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33213
Change subject: nb/amd/amdmct/mct: Remove duplicate if condition ......................................................................
nb/amd/amdmct/mct: Remove duplicate if condition
The case when Speed == 5 is already dealt with on line 111.
Change-Id: Icc41c00fb333a51001568f588c17f7b6c6a3a923 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1229626 --- M src/northbridge/amd/amdmct/mct/mctardk4.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33213/1
diff --git a/src/northbridge/amd/amdmct/mct/mctardk4.c b/src/northbridge/amd/amdmct/mct/mctardk4.c index d112c46..2e16a80 100644 --- a/src/northbridge/amd/amdmct/mct/mctardk4.c +++ b/src/northbridge/amd/amdmct/mct/mctardk4.c @@ -128,8 +128,6 @@ *AddrTmgCTL = 0x002F2F00; } else if (Speed == 1) { *AddrTmgCTL = 0x002F2F00; - } else if (Speed == 5) { - *AddrTmgCTL = 0x002F2020; } else { *AddrTmgCTL = 0x002F2F2F; }