build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31416 )
Change subject: SMBIOS: Update BIOS Information (Type 0) to version V3.2.0
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31416/4/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31416/4/src/arch/x86/smbios.c@378
PS4, Line 378: if (CONFIG_ROM_SIZE >= GiB) {
Comparisons should place the constant on the right side of the test
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec35c8c66210f0ddc07a2ca6f976a1f8fc53037d
Gerrit-Change-Number: 31416
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 14 Feb 2019 15:01:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment