Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47867 )
Change subject: mb/google/zork: Replace generic driver with sx9324 driver
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47867/5/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/47867/5/src/mainboard/google/zork/v...
PS5, Line 206: register "reg_adv_ctrl20" = "0xf0"
You can check the registers.h, it used the marco. […]
Yeah, I see. I don't really like it, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I869d0b6640247099ca489e96ed94e03811a04bf4
Gerrit-Change-Number: 47867
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Nov 2020 17:34:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment