Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47990 )
Change subject: soc/intel/common/fast_spi: Add extended decode window support ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47990/10/src/soc/intel/common/block... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47990/10/src/soc/intel/common/block... PS10, Line 265: #if CONFIG(FAST_SPI_SUPPORTS_EXT_BIOS_WINDOW) : /* : * Ensure that the base for the extended window in host space is a multiple of 32*MiB : * and size is fixed at 32*MiB. : */ : _Static_assert(ALIGN_UP(CONFIG_EXT_BIOS_WIN_BASE, 32 * MiB) == CONFIG_EXT_BIOS_WIN_BASE, : "Extended BIOS window base must be a multiple of 32 * MiB!"); : _Static_assert(CONFIG_EXT_BIOS_WIN_SIZE == (32 * MiB), : "Only 32MiB windows are supported for extended BIOS!"); : #endif
I have intentionally added these here because currently this configuration is based on how TGL defin […]
I think it is good, if this does change there may be other assumptions that need checked.
https://review.coreboot.org/c/coreboot/+/47990/10/src/soc/intel/common/block... PS10, Line 282: pci_write_config32(dev, SPI_CFG_BAR1, CONFIG_EXT_BIOS_WIN_BASE | PCI_BASE_ADDRESS_SPACE_MEMORY); wrap this?