Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63861 )
Change subject: soc/intel/elkhartlake: Implement TSN GbE driver ......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/63861/comment/176bfa35_8c3a96db PS2, Line 240: TSN_GBE_DRIVER
Since this would be an elkhart lake spcific driver should we name it EHL_TSN_DRIVER?
Renamed to EHL_TSN_DRIVER - you are right, this is EHL specific
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/63861/comment/d0173a96_d82e923a PS2, Line 15: if (!io_mem_base) { : printk(BIOS_ERR, "TSN GbE: Error can't find I/O MEM resource\n"); : return; : }
This check is not needed here as it is already done in find_resource() for you. […]
With the removal of the check I must also remove the first two lines for the time being. I will reimplement this at the first use.