Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44820 )
Change subject: util/ifdtool: Fix eSPI frequency as per Gen 11 SPI flash guide
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44820/1/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44820/1/util/ifdtool/ifdtool.c@641
PS1, Line 641: decode_espi_frequency(freq);
Where did the call to `decode_spi_frequency` go?
always this field is known as "eSPI / EC Bus Frequency" or "Read Clock Frequency" FLCOMP—Flash Components Register Bit 17-19
I could see an issue, thanks for highlighting will fix it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44820
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20840e6f931d7c1fabea0b6892e3bd19ead81168
Gerrit-Change-Number: 44820
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 26 Aug 2020 13:18:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment