Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36045 )
Change subject: mb/g/drallion: Enable privacy screen on Drallion variant ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36045/7/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36045/7/src/mainboard/google/dralli... PS7, Line 229: 0x0400
I actually think that the _ADR shoud be 0x80000400. […]
Yeah I agree that bit 31 should be set and I believe that bit 16 should be set as well. My reading of the spec is that the values returned from _DOD should be exactly the _ADR of each device. In src/drivers/intel/gma/acpi.c bits 31 and 16 are always set in _DOD and always cleared in _ADR and I think that is wrong according to the spec.