Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39114 )
Change subject: mb/google/dedede: Add GPIO list
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
What's the purpose of this commit? Why not just leave this out until you have the initial GPIO assignment?
- To park the GPIOs in a known safe state.
- Debugging - If FSP configures GPIOs, then we can identify that and figure out the reason.
- Review - Easy for reviewers to point out any unconfigured GPIOs when adding support for individual devices/components.
Also only after adding this, found that the required GPIO support for JSL is not added. There are lots of differences between GPIO communities and groups between TGL and JSL.
Can you add some of that explanation into the commit msg?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39114
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5293536f66a6b08c9c2d2a6281684755a0c0b1b3
Gerrit-Change-Number: 39114
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 28 Feb 2020 19:47:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment