[coreboot-gerrit] Change in coreboot[master]: coreboot_table: Use fmap_locate_area_as_rdev() for fmap_offset

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35639 )

Change subject: coreboot_table: Use fmap_locate_area_as_rdev() for fmap_offset
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h 
File src/include/fmap.h:

https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h@23 
PS1, Line 23: int find_fmap_directory(struct region_device *fmrd);
> Ah good point. I missed that this was the only user of find_fmap_directory() outside of fmap. […]

Done

https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h@53 
PS1, Line 53: uint64_t get_fmap_flash_offset(void);
> I thought of doing that initially, but skipped it looking at all the steps it would take to parse th […]

Done

https://review.coreboot.org/c/coreboot/+/35639/1/src/lib/coreboot_table.c 
File src/lib/coreboot_table.c:

https://review.coreboot.org/c/coreboot/+/35639/1/src/lib/coreboot_table.c@a2... 
PS1, Line 279: if (find_fmap_directory(&fmrd) == 0)
             : 		bmp->fmap_offset = region_device_offset(&fmrd);
> Would changing this to […]

Done