Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45636 )
Change subject: vendorcode/google: consolidate strong mainboard_get_dram_part_num routines ......................................................................
Patch Set 25:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45636/25/src/soc/intel/alderlake/ro... File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45636/25/src/soc/intel/alderlake/ro... PS25, Line 61: dram_part_num = mainboard_get_dram_part_num(); I think dram_part_num_len should be set here instead of inside the loop.
https://review.coreboot.org/c/coreboot/+/45636/25/src/soc/intel/elkhartlake/... File src/soc/intel/elkhartlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45636/25/src/soc/intel/elkhartlake/... PS25, Line 62: dram_part_num = mainboard_get_dram_part_num(); Same comment about dram_part_num_len as in alderlake.
https://review.coreboot.org/c/coreboot/+/45636/25/src/soc/intel/jasperlake/r... File src/soc/intel/jasperlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45636/25/src/soc/intel/jasperlake/r... PS25, Line 62: dram_part_num = mainboard_get_dram_part_num(); Same here for dram_part_num_len.
https://review.coreboot.org/c/coreboot/+/45636/25/src/soc/intel/tigerlake/ro... File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/45636/25/src/soc/intel/tigerlake/ro... PS25, Line 62: dram_part_num = mainboard_get_dram_part_num(); dram_part_num_len should be added here instead of inside the loop.
https://review.coreboot.org/c/coreboot/+/45636/25/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/dram_part_num_override.c:
PS25: This file should go in the previous CL that adds the Kconfig for CHROMEOS_DRAM_PART_NUMBER_IN_CBI