View Change

5 comments:

• File src/soc/intel/alderlake/romstage/romstage.c:

  • Patch Set #25, Line 61: dram_part_num = mainboard_get_dram_part_num();

    I think dram_part_num_len should be set here instead of inside the loop.

• File src/soc/intel/elkhartlake/romstage/romstage.c:

  • Patch Set #25, Line 62: dram_part_num = mainboard_get_dram_part_num();

    Same comment about dram_part_num_len as in alderlake.

• File src/soc/intel/jasperlake/romstage/romstage.c:

  • Patch Set #25, Line 62: dram_part_num = mainboard_get_dram_part_num();

    Same here for dram_part_num_len.

• File src/soc/intel/tigerlake/romstage/romstage.c:

  • Patch Set #25, Line 62: dram_part_num = mainboard_get_dram_part_num();

    dram_part_num_len should be added here instead of inside the loop.

• File src/vendorcode/google/chromeos/dram_part_num_override.c:

  • Patch Set #25:

    This file should go in the previous CL that adds the Kconfig for CHROMEOS_DRAM_PART_NUMBER_IN_CBI

To view, visit change 45636. To unsubscribe, or for help writing mail filters, visit settings.