Kane Chen has posted comments on this change. ( https://review.coreboot.org/19992 )
Change subject: soc/intel/skylake: Add macro for setting GPIO interrupt trigger mode.
......................................................................
Patch Set 4:
Hi Aaron,
In OS, kernel already sets the gpio interrupt trigger mode to edge, but apparently coreboot sets it back to level during s3 resume.
I think coreboot should at least make the trigger mode same with GpioInt.
thanks.
--
To view, visit
https://review.coreboot.org/19992
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42b9cd80b494e24c55b97e54cdf59bfd24dd9054
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: No