15 Jan
2019
15 Jan
'19
12:13 p.m.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30790 )
Change subject: sb/intel/common: Show "Add gigabit ethernet firmware" only for boards that need it ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+2
Patch Set 1: Code-Review+1
(1 comment)
Oh, I missunderstood this switch. I am fine with this change, sorry for the noise.
Then, does this mean the internal GBE is used or not?
It is not used. I can disable it in a later patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30790
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfb07902ad93fe5ff2bd4f869abcf6579f7b5a79
Gerrit-Change-Number: 30790
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Tatje jan@jnt.io
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jan Tatje jan@jnt.io
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: York Yang york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 15:13:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment