Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35799 )
Change subject: soc/intel/sgx: make SGX a Kconfig option ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35799/2/src/soc/intel/apollolake/me... File src/soc/intel/apollolake/memmap.c:
https://review.coreboot.org/c/coreboot/+/35799/2/src/soc/intel/apollolake/me... PS2, Line 41: PrmrrSize
Correct,it is "just ram" but as soon as PRMRR gets enabled and locked, any access to it will be si […]
We need to figure out: - is prmrr needed for anything else? (browell configures it, but does not have sgx) - when not enabling prmrr, do we need to adapt the memory layout anyways, e.g. because fsp expects it? or should we configure it to the lowest value (1MB)? - should we simply detect and set the highest possible prmrr or let the user choose and die() if the selected value is unsupported?