Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46818 )
Change subject: soc/intel/xeon_sp: Configure DPR on all stacks
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46818/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46818/10//COMMIT_MSG@9
PS10, Line 9: TSEG_BASE and the cbmem_top
Since TSEG base >= cbmem_top, I'd say:
... cbmem_top and TSEG base.
https://review.coreboot.org/c/coreboot/+/46818/10/src/soc/intel/xeon_sp/unco...
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/46818/10/src/soc/intel/xeon_sp/unco...
PS10, Line 234:
Spurious \n
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46818
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d34e50b3d577f19172619156352534f740ea6b
Gerrit-Change-Number: 46818
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 14 Nov 2020 13:00:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment