Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )
Change subject: mb/google/hatch: Update GPIO settings
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/...
PS4, Line 109: /* B19 : Set to NF1 */
: PAD_CFG_NF(GPP_B19, NONE, DEEP, NF1),
This is still a NC in the Hatch 2.1 reference schematic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2
Gerrit-Change-Number: 32176
Gerrit-PatchSet: 4
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Apr 2019 02:37:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment