Attention is currently required from: Jamie Chen, Peichao Wang, Karthik Ramasubramanian.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55718 )
Change subject: mb/google/dedede/var/blipper: Enable ELAN touchscreen
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/dedede/variants/blipper/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55718/comment/a3d89c5a_b05ffdf1
PS3, Line 140: register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
Please check if the irq needs be changed to ACPI_IRQ_EDGE_LOW.
Thanks for your warning. IRQ is still level low after confirmation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55718
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife77d514d9906049f237edd169bc07bb53c48579
Gerrit-Change-Number: 55718
Gerrit-PatchSet: 3
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ginger Zhang
zhangqingchun@huaqin.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie.chen@intel.com
Gerrit-CC: Krystal Han
hanlijing@huaqin.corp-partner.google.com
Gerrit-CC: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 25 Jun 2021 02:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Chen
jamie.chen@intel.com
Gerrit-MessageType: comment