EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37594 )
Change subject: libpayload/drivers/i8042: Add AT translated Keyboard support
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37594/4/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37594/4/payloads/libpayload/drivers...
PS4, Line 332: /* Enable keyboard translated */
: if (!i8042_cmd(I8042_CMD_RD_CMD_BYTE)) {
: int cmd = i8042_read_data_ps2();
: cmd |= I8042_CMD_BYTE_XLATE;
: if (!i8042_cmd(I8042_CMD_WR_CMD_BYTE))
: i8042_write_data(cmd);
: }
maybe pull this into a separate function. […]
oh, okay. I'll separate this. Maybe separate set scan code set as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1053e24e44c5bad28b56cc92d091e24f3d9b6fd
Gerrit-Change-Number: 37594
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Dec 2019 17:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment