Attention is currently required from: Sean Rhodes, Angel Pons, Maximilian Brune, Lean Sheng Tan.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Should have just said, "how the boot manager form work"...
Yeah, that is how the form IFR would work. Something creates `form ... endform` opcodes and a `goto ...` opcode, then a menu will work the way for example, the front page in EDK2 does.
I thought it would be moderately difficult to dynamically write FORM_OP IFR, so, I'm curious how you implemented something like it?
Either way, this patch has `sm_write_form()`, it's not an issue here, it's a to-do item on my patch.
File src/drivers/option/cfr.h:
https://review.coreboot.org/c/coreboot/+/74121/comment/54c98d79_74b59d6c PS3, Line 133: /* CFR_OPT_NAME opt_name */ : /* CFR_UI_NAME ui_name */ : /* CFR_UI_HELPTEXT ui_helptext (Optional) */ : Nit: Use long comment like the other structs, a short comment above for `lb_cfr_enum_value`, and reorder `default_value` to match above? I'll probably write a 'peek' type function for handling the optional UI text in EDK2, so this isn't too important, though it keeps the flow the same.