Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45390 )
Change subject: nb/intel/x4x: Relocate read to TPM base address
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45390/4/src/northbridge/intel/x4x/r...
File src/northbridge/intel/x4x/raminit.c:
https://review.coreboot.org/c/coreboot/+/45390/4/src/northbridge/intel/x4x/r...
PS4, Line 621: read8((void *)TPM_BASE_ADDRESS);
you don't use the information gathered, so this is as useless as before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic36a2810a861758ce733fe80c4e555439e2ffb7b
Gerrit-Change-Number: 45390
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Sep 2020 05:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment