Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 14:
(3 comments)
`
https://review.coreboot.org/c/coreboot/+/48286/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48286/6//COMMIT_MSG@14 PS6, Line 14: [to be updated]
Needs to be updated before submitting CL.
Done
https://review.coreboot.org/c/coreboot/+/48286/7/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48286/7/src/soc/intel/common/block/... PS7, Line 416: edi
Yes that's very good catch. I will change now.
Done
https://review.coreboot.org/c/coreboot/+/48286/8/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/48286/8/src/soc/intel/common/block/... PS8, Line 418: bx
This will have to be ecx since ebx actually holds the non-eviction mask at this point.
Ack