3 Apr
2022
3 Apr
'22
6:59 p.m.
Attention is currently required from: Felix Singer, Damien Zammit, Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62808 )
Change subject: mb/hp/z220_series: Convert z220_sff_workstation into variant ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/hp/z220_series/variants/z220_sff_workstation/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62808/comment/35487efc_073f22f9 PS2, Line 5: subsystemid 0x103c 0x1791 inherit
Yes, without this line, the overridetree stops the devicetree from inheriting it because of it being […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/62808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6aaac75216b2d7c8bb48801454ce616ace3b1422
Gerrit-Change-Number: 62808
Gerrit-PatchSet: 3
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Sun, 03 Apr 2022 18:59:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Damien Zammit
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment