[coreboot-gerrit] Change in coreboot[master]: nb/via/vx900: Assert framebuffer size is within limits

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34355 )

Change subject: nb/via/vx900: Assert framebuffer size is within limits
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34355/1/src/northbridge/via/vx900/m... 
File src/northbridge/via/vx900/memmap.c:

https://review.coreboot.org/c/coreboot/+/34355/1/src/northbridge/via/vx900/m... 
PS1, Line 82: int
> why the int?

If size_mb is somehow zero, then fb_pow will underflow in the subtraction to 255. This technically would also be caught by the added check, but changing it to an int is less weird. I suppose I should explain that in the commit message.